projectcontour / contour

Contour is a Kubernetes ingress controller using Envoy proxy.
https://projectcontour.io
Apache License 2.0
3.71k stars 672 forks source link

Add a separate label for envoy or contour #6488

Open yangyy93 opened 3 months ago

yangyy93 commented 3 months ago

What question do you have?: The field PodAnnotations is now defined in the Spec of ContourDeployment, through which Annotations can be added to contour or envoy pods separately, but for Labels, there is no similar definition. I found that there was a PR (#5543) that implemented this function, but Closed due to merge of #5968. Because of the merger of #5968, now we can either add annotations to envoy or contour separately, or add (same) annotations to both contour and envoy through gateway.infrastructure.annotation; I think it is a good idea to provide the ability to configure separate labels for envoy or contour for more flexible use.

yangyy93 commented 3 months ago

@skriss @sunjayBhatia have any opinions on this issue?

github-actions[bot] commented 1 month ago

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

You can:

Please send feedback to the #contour channel in the Kubernetes Slack

wilsonwu commented 3 weeks ago

@skriss @sunjayBhatia any comments for this? We'd like to contribute it.