Open Elftone opened 5 years ago
Would you please open the PTG tab, press F12 to open the developer tools. Open the tab console and reload PTG with F5. Then see if any error appears in the console.
Here's the error message I get:
URIError: malformed URI sequence tabNodes.js:85:80
Thanks!
🤔 tabNodes.js isn't from PTG. EDIT: wrong assumption.
Is this the complete error? Would you please provide a screenshot from the error?
Note: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Malformed_URI
Sure - one of the error, and one of tabNodes.js. Thanks!
I thought in the wrong direction. It is a PTG file: https://github.com/projectdelphai/panorama-tab-groups/blob/12951f8976f54330c5ebe5051fab86875752df2a/src/js/view/tabNodes.js#L85
Please click in the developer tools, in the tab you have opened, on the number of line 85 (on the left). Then reload PTG. Then hover the tab in line 83 and take a screenshot.
I'm not getting a pop-up when I hover the cursor over the tab in line 83. Does it have to be enabled somewhere?
If the line 85 is highlighted like in my screenshot, the debugger is stop in this line after the reload. It could stop right before the error appears. But it's possible, that it's not the first tab that is causing the issue. It's hard to explain how to debug this issue.
Has anyone a suggestion?
EDIT: Another idea. Instead of the click on line 85, please click on the "Pause on exception" (on the right beneath "Breakpoints". Then reload. I hope it stops right on your exception. Then we could look for the tab.url
, which causes this issue.
I do understand, and I appreciate you helping me.
I tried your other idea and got this:
Ok. On the right, beneath "Scopes", expand tab: {...}
and look for the key url
.
EDIT: And look for the key title
, which might reveal the tab which causes this error.
Apologies for the delay in replying. Here's the URL of the tab which appears in the trace:
Ok, I test the URL later. Have you tried to close this specific tab?
I have now, and PTG is now showing the tab groups page correctly. Many, many thanks for your help!
I am glad it's work. Now we have to investigate why this URL throw this issue. Thank you for your help.
Here's the URL of the tab which appears in the trace:
This URL is indeed throw the exception when used in decodeURI()
.
The URL is used in the title while hovering a tab within a group:
I would suggest that we remove the URL from this place.
Hello! Have the same problem after the last update - Discovering this post I tried to debug: Similar problem like above - but Problem with every URL wich is the first tab. Closed the first, than the next tab makes the problem. (Maybe the one who are fixed to the begin)
After another try another problem was shown:
Cannot load the screenshot unfortunately... :-(
Its line 201 await testImage (tab.favIconUrl); url is https://www.laborsieb.de/
I now downgraded to the version before... Please check this out!
Worked fine before and one of the Adds I needed most! Thanks for that!
bye, Axel
Now it worked:
Hi @AxelKoelb,
url is https://www.laborsieb.de/
I tested this URL with my local PTG v0.8.9. It worked without issues.
Have the same problem after the last update
Is it really the same. What is the exact error within the console?
Do you have other tab-related addon installed? Would you please test it with disabling each addons (one after the other).
Hi Vaxul,
Thanks for your answer!
Tested with Add Ons deactiveted: no change I am a "taboholic" so about 1300 tabs opend - maybe one reason?
Two different things appear while testing:
The file I mentioned above is closed - another comes up
The second - don´t know - only appears if the holding point is clicked?
So what can I do to furhter to find out whats wrong?
bye,
Axel
I am a "taboholic" so about 1300 tabs opend - maybe one reason?
This is hard. 🤣 I see you use a lot of other extensions. Maybe time for Firefox Refresh (fresh start from zero)? See about:support ❗️ but be aware that you will lose all addons and settings.
But let try another way.
Would you please test this version of PTG: https://github.com/vaxul/panorama-tab-groups/tree/bug/117_remove_url_from_tab_title First, disable your current PTG addons temporary:
To install develop version of PTG temporarily:
Cannot load the Add on temporary:
Während der Installation trat ein Fehler auf: File D:................\panorama-tab-groups-bug-117_remove_url_from_tab_title\src\js does not contain a valid manifest
Okay, had to click not on any but on manifest.json
:) Shows now vers. 0.8.9.
Thank you very much!!
Cool. The path from this version was merged today and will be in the next release. Please wait patient.
I have the same issue but the above URL (https://github.com/vaxul/panorama-tab-groups/tree/bug/117_remove_url_from_tab_title) returns 404. Where can I find another develop snapshot of PTG?
It is merged in the current master but not yet released: https://github.com/projectdelphai/panorama-tab-groups
I used https://codeload.github.com/vaxul/panorama-tab-groups/zip/feature/113_allow_removal_of_shortcuts It now shows a group of tabs on my desktop (I don't remember but I've between 500-700 tabs) But on my laptops, it says I've ~1650tabs but only show the PTG tab in the group…
Ex, here it shows I've 1636 tabs but only show the last tab , whatever the size of the firefox window and the size of the PTG view
https://github.com/vaxul/panorama-tab-groups/tree/feature/113_allow_removal_of_shortcuts
You could temporary try this branch. Then backup the tab groups in the PTG addon settings. Then restore the tab groups from the backup. It should open a new window with all tab groups.
Why didn't we fix this by displaying the url without using decodeURI
? It seems like there might be some use cases where you would like to see the url. For example, for tabs that have a blank title or tabs with the same title but different urls. Is there actually a reason to use decodeURI
there?
@crass
Why didn't we fix this by displaying the url without using decodeURI?
Can't say for sure. Might be an option.
I noticed today that when I click the PTG button, I am presented with a blank page instead of the usual Panorama View containing all of the groups I've created. I get the same result when using the Ctrl-Shift-F key combination. However, when I use Alt-W or Alt-Shift-W, I can cycle through groups as normal.
As it was working normally yesterday, I tried checking the options, updating to the latest version of PTG, restarting the browser, restarting Windows, exporting a backup, then re-importing it. None of these made any difference.
Is it possible I have inadvertently changed a setting that might have caused this? I left everything as it was installed. Versions are shown below. Many thanks.
Panorama Tab Groups 0.8.9, Firefox 67.0 (64-bit) updated May 23rd, Windows 10 64-bit updated May 15th.