projectdiscovery / gologger

A simple layer for leveled logging in go
MIT License
75 stars 24 forks source link

Switch from gopkg.in/djherbis/times.v1 to github.com/djherbis/times #34

Closed mikelolasagasti closed 1 year ago

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mikelolasagasti commented 1 year ago

The lint error is not related to this PR:

:error file=formatter/tee.go,line=43,col=3::ineffectual assignment to err (ineffassign)
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Mzack9999 commented 1 year ago

@mikelolasagasti Thanks for submitting this PR. After checking the dependencies trees at https://gopkg.in/djherbis/times.v1, it seems that v1 already points correctly to the latest version, which we obtain via dependantbot and released with bi-weekly automatic release. Hence I'm closing the PR as this update is already implicitly covered. Thanks!