search

projectdiscovery / notify

Notify is a Go-based assistance package that enables you to stream the output of several tools (or read from a file) and publish it to a variety of supported platforms.
https://projectdiscovery.io
MIT License
1.31k stars 132 forks source link

fix proxy setting when ratelimit is 0 #402

Closed AaronChen0 closed 2 months ago

AaronChen0 commented 3 months ago

Fix #403

Changes I make:

  1. defaultTransport should be used when ratelimit is 0.
  2. Add info about notify socks5 proxy support. net.http.Transport supports both http and socks5 proxy. Tested. Really works.
GeorginaReeder commented 3 months ago

Thanks for your contribution @AaronChen0 !

We also have a Discord server, which you’re more than welcome to join. It's a great place to connect with fellow contributors and stay updated with the latest developments!

dwisiswant0 commented 3 months ago

Could you please create the issue first, @AaronChen0?

AaronChen0 commented 3 months ago

The failed check is irrelevant to this pull request.

Switching branch from main to dev introduced a commit not by me. Is this a concern when later dev branch merges back to main branch?

dwisiswant0 commented 3 months ago

@AaronChen0 - you should rebase your branch.

AaronChen0 commented 2 months ago

@dwisiswant0. Rebase done.