search

projectdiscovery / nuclei-action

Vulnerability Scan with Nuclei
https://projectdiscovery.io/nuclei
MIT License
242 stars 70 forks source link

Compile latest changes #78

Closed felipesaezreyes closed 8 months ago

felipesaezreyes commented 9 months ago

It seems like a bunch of the latest changes done in the src/ folder weren't built into dist/ which means they aren't used when the action is invocated.

I ran npm run build and this is the result of that command.

olearycrew commented 9 months ago

Thanks for this @felipesaezreyes

@ehsandeep maybe we should not include the dist folder in the repo? Or automate this somehow if that is needed.

RamanaReddy0M commented 8 months ago

We use this way to avoid jobs having to install npm modules and create a final version without dependencies on our code.

Ref: https://github.com/projectdiscovery/nuclei-action?tab=readme-ov-file#contributing cc: @olearycrew

olearycrew commented 8 months ago

@RamanaReddy0M in that case maybe we should have an action that automatically does that for any change?

RamanaReddy0M commented 8 months ago

+1, I'll add a workflow which does this job for us.

RamanaReddy0M commented 8 months ago

https://github.com/projectdiscovery/nuclei-action/issues/81 @olearycrew

ehsandeep commented 8 months ago

thank you @felipesaezreyes for the PR, closing this one as it got merged indirectly with https://github.com/projectdiscovery/nuclei-action/pull/80