projectfluent / fluent-rs

Rust implementation of Project Fluent
https://projectfluent.org
Apache License 2.0
1.08k stars 97 forks source link

Fix useGrouping in fluent-bundle #215

Closed dminor closed 3 years ago

dminor commented 3 years ago

The useGrouping number option is assigned a default value, but never updated. In the Intl.NumberFormat API, useGrouping is a boolean. Since Fluent does not support boolean values, a string is used here instead. If the value is "false", grouping is disabled, otherwise it is enabled.

This was missed because the unit tests tested for "true", which is the default value for useGrouping.

zbraniecki commented 3 years ago

thank you!