Closed MathieuTricoire closed 1 year ago
It seems reasonable to me. I'm marking request changes for a simple unit test. Most the existing tests are more on the integration level, but a unit test here should be good enough for merging.
I've added an integration test, I think it fits more with what exists, is that ok?
The CI was failing for code coverage, but it's passing in #276, so this looks fine to merge.
Any thoughts about implementing
From
forOption
?:I find interesting to allow something like this: