search

projectfluent / fluent-rs

Rust implementation of Project Fluent
https://projectfluent.org
Apache License 2.0
1.04k stars 95 forks source link

Start using workspace dependencies #297

Closed adriantombu closed 1 year ago

adriantombu commented 1 year ago

As discussed in https://github.com/projectfluent/fluent-rs/pull/282#discussion_r1035019918 here's a separate PR to test the ability to use workspace dependencies that were introduced in Rust 1.64.

From what I see in the Firefox Rust update policy it should be ok as this is the Rust version used in the latest stable release of Firefox (lucky us haha).

Screenshot 2022-11-30 at 12 46 55

gregtatum commented 1 year ago

This also needs testing with ./mach vendor rust on the Firefox codebase. I think you can run it locally by replacing the paths to a local repo, and then running it. Our vendor script uses a custom python vendoring system that may not yet know about what cargo and rustc can do yet.

https://firefox-source-docs.mozilla.org/build/buildsystem/rust.html

Would you be interested in taking a stab at this @adriantombu or would you prefer me or @nordzilla to try it. It may be a bit before we can get to it if it's us.

gregtatum commented 1 year ago

We need to document how to do the local testing in https://github.com/projectfluent/fluent-rs/tree/main/docs

adriantombu commented 1 year ago

Would you be interested in taking a stab at this @adriantombu or would you prefer me or @nordzilla to try it. It may be a bit before we can get to it if it's us.

@gregtatum I can have a look at that, I have some free time currently 😁

adriantombu commented 1 year ago

I tested against the Firefox codebase locally successfully and added a documentation file to explain the different steps to achieve it.

gregtatum commented 1 year ago

This is still in my review queue, but I haven't had time to look at it yet.

gregtatum commented 1 year ago

@adriantombu Thanks once again for the contribution! 🎉