search

projectfluent / fluent

Fluent — planning, spec and documentation
https://projectfluent.org
Apache License 2.0
1.37k stars 43 forks source link

Fix #323, add more line continuations to cr and crlf tests #324

Closed Pike closed 2 years ago

Pike commented 3 years ago

I'm not happy with the cr test. It lumps all the combinations into the comments production, instead of actually testing cr handling in the various scenarios.

@zbraniecki, @stasm, any comments?

I'm entertaining the idea of splitting the cr test into a fixture for each block, but that's also very ad-hoc. Maybe with a trailing comment to explain what the test does and why.

zbraniecki commented 3 years ago

Could you introduce "valid" lines as separators?

Pike commented 3 years ago

Not sure if that makes the problem easier. We'd need to flag the file as binary with git attributes, and it'd reduce the number of editors that can actually edit the file. I'm already at the point where vscode doesn't work, and I tweak with vi and python byte strings.

Pike commented 3 years ago

I'm not particularly fond of this patch, but I also don't have a better idea.

Pike commented 3 years ago

@zbraniecki , any takes on this?

Can't flag anyone for review myself anymore, due to permissions.

zbraniecki commented 3 years ago

@stasm - could you help us with your perspective on that?