projectfluent / fluent

Fluent — planning, spec and documentation
https://projectfluent.org
Apache License 2.0
1.4k stars 45 forks source link

`resolveVariableReference` enforces variables names to be own properties #340

Closed caridy closed 2 years ago

caridy commented 2 years ago

This seems to be very restrictive, and instead, Reflect.has() is probably better. In our case, the args structure provided to messages might be optimized in various ways (very likely some immutable structure) that does not necessary flatten all data into an object, and instead it might rely on the __proto__ chain.

caridy commented 2 years ago

Closing since this issue belongs to fluent.js instead.