projectglow / glow

An open-source toolkit for large-scale genomic analysis
https://projectglow.io
Apache License 2.0
270 stars 111 forks source link

Fix VEP parsing failures stemming from indels #402

Closed bboutkov closed 3 years ago

bboutkov commented 3 years ago

Signed-off-by: Boris Boutkov boris.boutkov@gmail.com

What changes are proposed in this pull request?

Small collection of Int to String conversions for VEP parsing. Fixes #389

How is this patch tested?

codecov[bot] commented 3 years ago

Codecov Report

Merging #402 (f5b4553) into master (509d9af) will decrease coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   93.69%   93.63%   -0.07%     
==========================================
  Files          95       95              
  Lines        4824     4824              
  Branches      466      466              
==========================================
- Hits         4520     4517       -3     
- Misses        304      307       +3     
Impacted Files Coverage Δ
...ain/scala/io/projectglow/vcf/AnnotationUtils.scala 100.00% <100.00%> (ø)
...low/vcf/InternalRowToVariantContextConverter.scala 92.34% <0.00%> (-0.91%) :arrow_down:
...low/vcf/VariantContextToInternalRowConverter.scala 94.96% <0.00%> (-0.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 509d9af...f5b4553. Read the comment docs.

williambrandler commented 3 years ago

looks like the codecov failed because the test coverage dropped by 0.07% Will have to wait for either @karenfeng or @kianfar77 to come back from PTO and adjust this setting, as I do not have access. Therefore expect we will have to wait to merge this into glow v1.1.1