Closed williambrandler closed 2 years ago
Merging #406 (7e806f7) into master (8a27c0b) will increase coverage by
0.00%
. The diff coverage is100.00%
.:exclamation: Current head 7e806f7 differs from pull request most recent head 28e61e3. Consider uploading reports for the commit 28e61e3 to get more accurate results
@@ Coverage Diff @@
## master #406 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 95 95
Lines 4823 4824 +1
Branches 473 466 -7
=======================================
+ Hits 4519 4520 +1
Misses 304 304
Impacted Files | Coverage Δ | |
---|---|---|
core/src/main/scala/io/projectglow/Glow.scala | 95.83% <100.00%> (+0.18%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5f28878...28e61e3. Read the comment docs.
Thanks for taking care of this @williambrandler! I see the Maven release here https://repo1.maven.org/maven2/io/projectglow/ but not in Central https://search.maven.org/search?q=g:io.projectglow; do you know what's going on?
@karenfeng it wasn't there when I made the PR
(docs say it takes a few hours to show up so was banking on it being there by the time you read this!)
It is on maven central now https://search.maven.org/search?q=glow
thanks @karenfeng I followed those instructions...altho now it is saying 39 files changed with all the changes in the new version
created a new PR because I screwed this one up fixing DCO
What changes are proposed in this pull request?
Release v1.0.0. There are now in Maven Central and pypi.
How is this patch tested?
(Details)