Closed dmoore247 closed 2 years ago
Merging #408 (2ce9d4a) into master (351befb) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 95 95
Lines 4824 4824
Branches 466 466
=======================================
Hits 4520 4520
Misses 304 304
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 351befb...2ce9d4a. Read the comment docs.
thanks @dmoore247, your commit is just missing a signoff from DCO
Given that this is a small change, the safest way to fix this is to create a new branch, add the fix and then make sure to signoff your commit using "--signoff" or "-s"
git commit -m "initial commit" --signoff
@dmoore247 please resolve the signoff (DCO) when you get a chance, want to include your contribution in the v1.1.1
release notes, which I plan to do tomorrow
manually approving commit sign off
Fixed code sample, spark variable should be assigned to glow.register(spark)
What changes are proposed in this pull request?
Fix code example
How is this patch tested?
(Details)