search

projectglow / glow

An open-source toolkit for large-scale genomic analysis
https://projectglow.io
Apache License 2.0
263 stars 110 forks source link

reorder dockerfile #466

Closed williambrandler closed 2 years ago

williambrandler commented 2 years ago

Signed-off-by: William Brandler william.brandler@databricks.com

What changes are proposed in this pull request?

Was having issues getting the R Package bigsnpr working in Databricks after switching to Ubuntu 20.04, and after adding bgenix into this container.

Discussed this with the author of bigsnpr, https://github.com/privefl/bigsnpr/issues/279. And he rightly pointed out that there was no clear reason why the tool should fail to install. We tested manually installing in databricks and this worked.

I decided to swap the order in which bigsnpr is built in two ways,

  1. relative to bgenix
  2. relative to other R packages in the container

And this worked. Not sure why, but can't hurt to reorder just in case

How is this patch tested?

(Details)

codecov[bot] commented 2 years ago

Codecov Report

Merging #466 (209e137) into master (a7db6b6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files          95       95           
  Lines        4849     4849           
  Branches      463      463           
=======================================
  Hits         4542     4542           
  Misses        307      307

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7db6b6...209e137. Read the comment docs.