projectglow / glow

An open-source toolkit for large-scale genomic analysis
https://projectglow.io
Apache License 2.0
262 stars 107 forks source link

define output_delta in 0_setup_constants_glow.py #483

Closed cameronraysmith closed 2 years ago

cameronraysmith commented 2 years ago

output_delta undefined in https://github.com/projectglow/glow/blob/master/docs/source/_static/zzz_GENERATED_NOTEBOOK_SOURCE/etl/3_delta_to_vcf.py presumably expected from https://github.com/projectglow/glow/blob/master/docs/source/_static/zzz_GENERATED_NOTEBOOK_SOURCE/0_setup_constants_glow.py#L179

What changes are proposed in this pull request?

define output_delta in https://github.com/projectglow/glow/blob/master/docs/source/_static/zzz_GENERATED_NOTEBOOK_SOURCE/0_setup_constants_glow.py#L179

How is this patch tested?

https://github.com/projectglow/glow/blob/master/.circleci/config.yml#L268

codecov[bot] commented 2 years ago

Codecov Report

Merging #483 (57e83c0) into master (77827ba) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files          95       95           
  Lines        4875     4875           
  Branches      457      457           
=======================================
  Hits         4566     4566           
  Misses        309      309           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77827ba...57e83c0. Read the comment docs.

williambrandler commented 2 years ago

hey Cameron, thank you for spotting this! Will merge this in, in order to make the tests pass:

Please can you also drop in an html version of the notebook following this here:

https://glow.readthedocs.io/en/latest/contributing.html#modify-or-add-notebooks

And then convert to python following the script.

Also please sign off commits:

git commit -m "initial commit" --signoff

The easiest way to rectify signoffs is to close the PR and reopen. Or follow here: https://github.com/projectglow/glow/pull/483/checks?check_run_id=5160914682

cameronraysmith commented 2 years ago

Hello @williambrandler, those issues have now been addressed. Many thanks.

williambrandler commented 2 years ago

Thanks @cameronraysmith!