projectglow / glow

An open-source toolkit for large-scale genomic analysis
https://projectglow.io
Apache License 2.0
262 stars 106 forks source link

Suppress exception when closing stdin writer in pipe transformer #627

Closed henrydavidge closed 3 months ago

henrydavidge commented 3 months ago

What changes are proposed in this pull request?

In unit tests we run programs that don't read from stdin. The process exits before the stream can be closed.

How is this patch tested?

(Details)

To run Spark 4 tests against your PR, include [SPARK4] in the title.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.36%. Comparing base (cbe8ebd) to head (aa3a2bf). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #627 +/- ## ======================================= Coverage 92.36% 92.36% ======================================= Files 126 126 Lines 7357 7357 Branches 606 626 +20 ======================================= Hits 6795 6795 Misses 562 562 ``` | [Flag](https://app.codecov.io/gh/projectglow/glow/pull/627/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/projectglow/glow/pull/627/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow) | `92.36% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.