projectglow / glow

An open-source toolkit for large-scale genomic analysis
https://projectglow.io
Apache License 2.0
262 stars 106 forks source link

Write VCFs from DataFrames with byte/short/long/float fields; read VCFs with spaces in the file name #649

Closed henrydavidge closed 3 months ago

henrydavidge commented 3 months ago

What changes are proposed in this pull request?

Resolves #525 #474

How is this patch tested?

(Describe any other testing)

To run Spark 4.0 tests, add [SPARK4] to the pull request title.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.35%. Comparing base (2ec1a6d) to head (ab6e96d).

Files Patch % Lines
...n/scala/io/projectglow/vcf/VCFSchemaInferrer.scala 93.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #649 +/- ## ========================================== - Coverage 92.36% 92.35% -0.01% ========================================== Files 126 126 Lines 7357 7368 +11 Branches 626 625 -1 ========================================== + Hits 6795 6805 +10 - Misses 562 563 +1 ``` | [Flag](https://app.codecov.io/gh/projectglow/glow/pull/649/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/projectglow/glow/pull/649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow) | `92.35% <96.66%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.