projectglow / glow

An open-source toolkit for large-scale genomic analysis
https://projectglow.io
Apache License 2.0
262 stars 106 forks source link

Make variant splitter work with Photon #655

Closed henrydavidge closed 2 months ago

henrydavidge commented 2 months ago

What changes are proposed in this pull request?

How is this patch tested?

Manual testing to make sure everything runs in Photon now

To run Spark 4.0 tests, add [SPARK4] to the pull request title.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.42857% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 92.37%. Comparing base (6622f94) to head (bd7ecfb).

Files Patch % Lines
.../projectglow/sql/expressions/glueExpressions.scala 96.82% 2 Missing :warning:
...rc/main/scala/io/projectglow/TestAssemblyJar.scala 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #655 +/- ## ======================================= Coverage 92.36% 92.37% ======================================= Files 126 127 +1 Lines 7377 7419 +42 Branches 628 605 -23 ======================================= + Hits 6814 6853 +39 - Misses 563 566 +3 ``` | [Flag](https://app.codecov.io/gh/projectglow/glow/pull/655/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/projectglow/glow/pull/655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow) | `92.37% <96.42%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.