search

projectglow / glow

An open-source toolkit for large-scale genomic analysis
https://projectglow.io
Apache License 2.0
262 stars 106 forks source link

Setting upper threshold on pandas <2.0.0 #660

Closed zyd14 closed 2 months ago

zyd14 commented 2 months ago

What changes are proposed in this pull request?

Pinning pandas to < 2.0.0 in setup.py

How is this patch tested?

(Describe any other testing)

To run Spark 4.0 tests, add [SPARK4] to the pull request title.

henrydavidge commented 2 months ago

cc @kermany I think it would be better to replace the uses of append with pd.concat so that the code works with both major pandas versions. As a workaround you should also be able to explicitly install a pandas version <2.0.0.

kermany commented 2 months ago

@henrydavidge agreed, we should change it to append (I will create a PR) in the meanwhile approve this.

henrydavidge commented 2 months ago

Yep, makes sense to me. Thanks @zyd14 @kermany

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.31%. Comparing base (c075763) to head (fd3879c). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #660 +/- ## ======================================= Coverage 92.31% 92.31% ======================================= Files 127 127 Lines 7440 7440 Branches 602 602 ======================================= Hits 6868 6868 Misses 572 572 ``` | [Flag](https://app.codecov.io/gh/projectglow/glow/pull/660/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/projectglow/glow/pull/660/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow) | `92.31% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=projectglow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.