Format / Refactor code - Githubissues

projectgoav / E.Deezer

Unoffical asynchronous Deezer .NET API

17 stars 11 forks source link

Format / Refactor code #82

Closed PoLaKoSz closed 4 years ago

PoLaKoSz commented 4 years ago

Remove unused using directives
Change visibility to internal when the actual class is internal too
Add _ prefix for fields
Remove unused DeserializeableExtensions class
Replace backing field with auto-property
Minify multiline property into one
Reorder alphabetically the using directives
Remove empty blank lines
Remove trailing spaces

Ref #78

projectgoav commented 4 years ago

Thanks for looking into this and doing what looks like a power of work. I'll give it a review over the next few days and we can take it from there .

projectgoav commented 4 years ago

Given the scope of these changes and some ideas I've had recently I'd like to use this work as a basis of a V5 re-write of some internals and how the internals are coupled and work together.

I think a V5 breaking change would allow for a consistant style to be applied and allow for any API breakages where they occur.

~~Could you re-target this branch to projectgoav:vFive ?~~

That way I can get your hardwork merged, tweak it around a little, apply additional cleanup and you're still attributed with the work :)

I've opened #84 as a tracking branch and will update it with a propsed roadmap of the changes based from Issue #78 in due course.

EDIT: Don't know why I asked if you could re-target the branch as I'm able to do it myself... Oops!

PoLaKoSz commented 4 years ago

Hi!

Sorry for not answering all requested changes, i didn't wanted to answer without trying out the endpoint responses.

But breaking up this PR even more PRs i think good idea too, but i probably won't have time till the weekend, sorry. I already made some local changes (i am in a middle of removing the IDeezerClient interface but the Mocking doesn't work without interfaces if i am not wrong).

projectgoav commented 4 years ago

I'm happy to keep this PR up and get it merged without you breaking it up. Was just a heads-up in the future to make it easier on reviewers :)

Take your time on changes as well. I don't have a huge amount of time outside of work to work on things so there really is no rush at all.

PoLaKoSz commented 4 years ago

No, You were right about breaking this up to smaller pieces, when i started this PR i didn't expected to become this large so i am gonna close this and continue the discussion in the #84 PR because this is related to that.