projecthamster / hamster-shell-extension

Shell extension for hamster
http://projecthamster.org
GNU General Public License v3.0
217 stars 92 forks source link

[#212] Avoid crashes due to accessing destroyed objects #238

Closed rhertzog closed 6 years ago

rhertzog commented 6 years ago

The crashes that I have been experiencing all have backtraces leading back to the "refresh" event and error messages explaining that we are trying to use objects that have been destroyed.

This is the only place where we are destroying objects explicitly instead of relying on the garbage collector. To fix the crash, I'm simply using the remove_all_children() method instead of the destroy_all_children() one.

Fixes #212