Extension configuration : add an option 'center' in "Positioning" configuration (without replacing the calendar)

[MTindev]

In the gnome shell extension configuration panel, a new option has been added to the Positioning select : center, which displays the extension at the center of the Gnome top menu bar, and this, without replacing the calendar. Extension is displayed on its right.

[MTindev]

Here the result :

[mwilck]

This can't be merged as-is. It needs a non-trivial rebase to the current develop branch. Not your fault @MTindev, we were far too slow with reviewing PRs.

I have rebased it and pushed the result under my positioning-center branch (perserving your authorship, @MTindev). @MTindev, I'd create a PR for your branch, but the merge fails. You'd need to reset your branch to mine in order to bring this PR here into a mergeable state.

I have a portrait screen, where the optical difference between the default placement and the new "center" placement is minimal, except that the date widget is not in the center any more, which I find sort of confusing. With a horizontal screen setup, "center" positioning would make more sense, I suppose.

So - do we want to merge this? One the one hand, it doesn't hurt to have the option and at least one user wants it; also, the new placement plays more nicely with the general GNOME shell environment than replacing the calendar. OTOH, the benefit is limited, the optical result is debatable, and it sort of goes against the KISS principle (but that can be said for the "placement" option in general).

Opinions, please. And @MTindev, please indicate if you are still interested, we couldn't blame you if you said "no".

[hedayat]

Actually, I think this is more useful than replacing the calendar. To be honest, I find both replacing the calendar and activities a bit weird; so I wanted to remove options I'd remove those!

[MTindev]

Hello @mwilck, and @hedayat,

Thanks for the (late) answer (BTW, no problem !).

As you can guess by seeing my fork, I have not maintained it (I have worked on my local copy for a while but stopped). With successive fresh OS installs, I came back to this main repo.

The "center" positon, in landscape (and more in a 4K screen), would be very convenient. This Gnome extension is one of my favorites, and be able to keep an eye on it, easily, centered, is a good choice, I think.

So, two options if you're OK to keep it :

• either we forget the paternity, and you can adjust/include the instructions in current code,
• either I reset my branch, as you proposed, next days (last week).

According to your delay and willing. If it is the simplest for you, you can forget my PR and do the trick. Tell me.

Now that the repo is maintained, I'm not without doing some PR in future times if necessary, after sharing ideas with you and others.

Thanks,

[mwilck]

Thanks for the response, @MTindev. After your and @hedayat's comments, I agree this is a nice improvement.

Created #345. @MTindev, as you can see your authorship on the main change is preserved. I suggest that, if everyone agrees, @hedayat merge #345, and we close this one.

[hedayat]

I agree!

[MTindev]

Perfect, good job, thanks :)

[mwilck]

345 has been merged, closing.