projecthamster / hamster-shell-extension

Shell extension for hamster
http://projecthamster.org
GNU General Public License v3.0
215 stars 91 forks source link

Highlight when daily/weekly work is done #305

Closed jasuarez closed 4 years ago

jasuarez commented 5 years ago

This PR allows to optional establish the number of hours to done per day, and how many days per week to work, so the extension will change the color depending on the work done:

As example, supposing the goal is 8h/day, 5 days/week:

As said, this is an option that can be configure in the extension settings, as well as the number of hours per day, and number of days per week.

jasuarez commented 4 years ago

Closing this MR; I will post a new one with updated code.

DirkHoffmann commented 4 years ago

Just some thoughts, how this can be made more general, in case it will be picked up later.

I like the idea to prevent (or at least indicate) overwork with hamster. However, I think the 5×8h scheme is too simplistic to fit working hours in most cases. For instance I am presently in a 39h/week situation with 8+8+8+8+7 hours of work requested (officially). Previously I worked on a 8+8+8+8+4 scheme, and some of my colleages have 8+8+4+8+7. In addition, not all countries use Sunday as day of rest, which is a working day in the Middle East.

Therefore I think there should be three ways of parametrising possible, which steers the way of signalling the accounted hours with respect to the defined work pensum:

All this could easily go with an overhour counter as additional feature. But I would rather leave that to an external tool like the summary generator mentioned here.