Makeing it work with Gnome 40. #340

[hedayat]

Dear @jnphilipp , would you please resolve the conflict and let me know if this extension is compatible with older versions?

[jnphilipp]

Needed to make some changes, to get it to work on my Ubuntu 20.04 with 3.36. Haven't tested it on other versions.

[hedayat]

Needed to make some changes, to get it to work on my Ubuntu 20.04 with 3.36. Haven't tested it on other versions.

Thanks a lot. I think it is sufficient :)

[mwilck]

@jnphilipp, @hedayat, thanks for your work on this, highly appreciated.

Allow me to make a critical remark nonetheless. I wouldn't have acked this if I had looked at it before it was merged. Being late to the party, I can't seriously complain, but please mind the following for future PRs:

• There are non-trivial code changes in the merge commit 89a93f4, in extension/prefs.js. Apparently you added visible: true properties to various widgets. That was probably a correct change, but changes like this should go into a separate commit with appropriate message, rather than being hidden in a merge commit. Moreover, in a PR branch you should rebase the PR if upstream changes, rather than merging. It makes reading the history much easier later on.
• The header of the commit message is wrong English. This is just a nitpick, but it hurts my eye when I look at the commit history. I guess both of you aren't native English speakers. Me neither. Yet everyone can avoid mistakes like this simply by using a spell checker.

[hedayat]

OK.

To be honest, I didn't care about the merge instead of rebase thing, and while I myself usually do that, I'm not sure if it is good thing to require it.

Having separate commits is OK, I am just not knowledgeable enough about this JS/shell thing to decide about the boundries. :P

About the header, well, I'm really sorry, I'm not sure if I've even read it carefully back then :D Makeing is just too weird to even need a spell checker :P