matthijskooijman
commented
1 year ago I had a look over this PR, and good to point people at flathub. I do have two remarks:
- The instructions assume that a "flathub" remote is configured in the user's flatpak installation, but I recently tried installing something else from flathub and found that flathub was not configured by default and needed to be added manually first (this was On Ubuntu 22.10, not sure if this is universal). I would like these instructions to be useful to someone without prior knowledge about how flatpak works exactly, so if prior setup is needed, it would IMHO be good to at least mention this, and ideally also point to some official docs that document how to set this up.
- The PR as-is replaces info on how to install a separately downloaded flatpak file with how to install from flathub, but I think it would be good to (also) document the manual install method, since it allows installing flatpak files built manually or by our github workflows (i.e. to allow easily testing git master or a pull request). Bonus points for providing concise instructions on where to find such workflow-generated flatpak builds.
Having said that - I think that these are not blockers, we can also merge this and fix those issues later.
salim-b
Following https://github.com/projecthamster/hamster/issues/688