search

projecthamster / xfce4-hamster-plugin

A recreation of the gnome-shell 'hamster project extension' for the xfce4 panel.
http://projecthamster.org
GNU General Public License v2.0
27 stars 8 forks source link

rpmbuild with absolute path in installation #17

Closed rapgro closed 10 years ago

rapgro commented 10 years ago

/bin/sh ../libtool --mode=install /usr/bin/install -c libhamster.la '/home/build/rpmbuild/BUILDROOT/xfce4-hamster-plugin-1.3-0.2.fc20.x86_64/usr/lib64/xfce4/panel/plugins' libtool: install: /usr/bin/install -c .libs/libhamster.so /home/build/rpmbuild/BUILDROOT/xfce4-hamster-plugin-1.3-0.2.fc20.x86_64/usr/lib64/xfce4/panel/plugins/libhamster.so libtool: install: /usr/bin/install -c .libs/libhamster.lai /home/build/rpmbuild/BUILDROOT/xfce4-hamster-plugin-1.3-0.2.fc20.x86_64/usr/lib64/xfce4/panel/plugins/libhamster.la libtool: install: warning: remember to run `libtool --finish /usr/lib64/xfce4/panel/plugins'

sed -i 's:@ICON_NAME@:hamster-applet:g' /usr/share/xfce4/panel/plugins/hamster.desktop sed: couldn't open temporary file /usr/share/xfce4/panel/plugins/sedo2POH4: Permission denied

aquaherd commented 10 years ago

make && sudo make install works everywhere else. If rpmbuild is a fakeroot install, does it have a chroot install option?

Additionally, you should use configure option --with-icon-name=hamster-time-tracker for fedora since hamster-applet is deprecated there (see readme.md).

rapgro commented 10 years ago

Yes and no. Honestly, you should not do installation with absolute pathes. That could horribly fail when it's done with root rights, therefore your suggestion with chroot is right of course. But better use a macro'd path like $DESTDIR/usr/… rpmbuild does set all needed env variables / macros for that, I am wondering why your configure does not do that. Please fix asap due to blocker for downstream packaging.

rapgro commented 10 years ago

Thanks for the quick and fast fix.