Closed Shatur closed 6 months ago
Attention: Patch coverage is 89.04429%
with 47 lines
in your changes are missing coverage. Please review.
Project coverage is 90.86%. Comparing base (
fc189a7
) to head (868fca4
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/server_event.rs | 87.65% | 30 Missing :warning: |
src/client_event.rs | 90.11% | 17 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks! Ah, I forgot that you have a special use case... But yes, I think it would be better to implement this on your project side.
Attention: Patch coverage is 89.04429%
with 47 lines
in your changes are missing coverage. Please review.
Project coverage is 90.86%. Comparing base (
3146286
) to head (868fca4
).:exclamation: Current head 868fca4 differs from pull request most recent head 9f77642
Please upload reports for the commit 9f77642 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
src/server_event.rs | 87.65% | 30 Missing :warning: |
src/client_event.rs | 90.11% | 17 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Superseded #259.
Events was implemented this way since the initial release of replicon (it was more then a year ago, time flies quickly!), but it have some flaws:
I think it's time to revisit the implementation and fix the mentioned flaws.