search

projectharmonia / bevy_replicon

Server-authoritative networking crate for the Bevy game engine.
https://crates.io/crates/bevy_replicon
Apache License 2.0
350 stars 31 forks source link

Allow enabling replication manually #316

Closed aecsocket closed 3 months ago

aecsocket commented 3 months ago

Fixes https://github.com/projectharmonia/bevy_replicon/issues/310.

I've tested this with the bevy_replicon_renet test app, and made appropriate changes to preludes and imports so that the renet transport code doesn't have to be modified at all to work properly.

A ton of the diffs are just connected_client(s) -> replicated_client(s).

I wrote a test for this as well, but I don't know if the module I put it in is correct.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.60%. Comparing base (c0cc6b7) to head (1b066bf). Report is 3 commits behind head on master.

Files Patch % Lines
src/core/event_registry/server_event.rs 90.38% 5 Missing :warning:
src/core/replicated_clients.rs 77.77% 2 Missing :warning:
src/core/connected_clients.rs 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #316 +/- ## ========================================== - Coverage 90.82% 90.60% -0.22% ========================================== Files 36 37 +1 Lines 2235 2300 +65 ========================================== + Hits 2030 2084 +54 - Misses 205 216 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Shatur commented 3 months ago

I separated the rename from this PR into #319. Let's merge it first, will make the review process much easier.

Shatur commented 3 months ago

Good catch!