search

projectharmonia / bevy_replicon

Server-authoritative networking crate for the Bevy game engine.
https://crates.io/crates/bevy_replicon
Apache License 2.0
352 stars 31 forks source link

Bevy 0.15.0 RC #341

Open ironpeak opened 4 weeks ago

ironpeak commented 4 weeks ago

Migration to Bevy version 0.15.0-rc.2.

I'll update this PR once the 0.15.0 is out.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.99%. Comparing base (9a12fe8) to head (665d086). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #341 +/- ## ======================================= Coverage 89.99% 89.99% ======================================= Files 38 40 +2 Lines 2368 2369 +1 ======================================= + Hits 2131 2132 +1 Misses 237 237 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Shatur commented 2 weeks ago

@UkoeHB I pushed 2 commits (diff) that contain a small breaking change. Please, take a look. I originally wanted to open a PR for it, but unable to do so because this PR comes from a fork.

UkoeHB commented 2 weeks ago

@UkoeHB I pushed 2 commits (diff) that contain a small breaking change. Please, take a look.

I disagree with not including Replicated on all entities. I use Replicated as a universal marker to clean up entities when exiting a game's state scope. It is much more fragile to manually make sure every entity gets Replicated, and would inevitably lead to entity leaks.

It also permanently couples Replicated with component definitions, which seems unnecessary. It implies all replicated entities need to have some custom component with a #[requires(Replicated)], even if they don't need a custom component for anything.

Shatur commented 2 weeks ago

Good point, I will revert today after work.