Reported SNR for RTTY does not match uploaded value

projecthorus / horus-gui

Project Horus Telemetry Decoder

GNU General Public License v3.0

35 stars 9 forks source link

Reported SNR for RTTY does not match uploaded value #38

Closed zanco closed 5 months ago

zanco commented 5 months ago

Hi, when receiving RTTY the SNR indicator shows clearly positive SNR, but the value at the end of the string and value uploaded are negative.

Thanks Ben

darksidelemm commented 5 months ago

OK, I probably need to increase the 'lookback' period of the SNR calculation code when in RTTY mode.

For my own notes:

SNR obtained in get_latest_snr here: https://github.com/projecthorus/horus-gui/blob/master/horusgui/gui.py#L876
Check the current assumption about status updates is true.
Work out a suitable length when in RTTY mode (maybe double that for horus binary?)

darksidelemm commented 5 months ago

I currently don't have a functioning RTTY payload to test with. If you could get me a recording (with at least 5 or so packets) of a RTTY payload where this issue is occurring that will help me debug things...

zanco commented 5 months ago

[Uploading pa0cab-rtty-100bd-7n2.zip…]() (removed most of the spaces and beeps and the CW identification transmission.)

darksidelemm commented 5 months ago

That didn't appear to upload correctly. You can also email me the sample at vk5qi@rfhead.net

darksidelemm commented 5 months ago

OK, it looks like the time window for SNR calculations for RTTY will need to be expanded out to maybe 15 seconds to account for the pretty huge RTTY decoding buffer that it used within the demod.

darksidelemm commented 5 months ago

There's a test build of v0.3.17 with this fix here: https://github.com/projecthorus/horus-gui/actions/runs/8829173602

zanco commented 5 months ago

Let the image do the work :-)

Excellent work, now tested at 300 baud 8n2

Thanks !

darksidelemm commented 5 months ago

OK, this is released in 0.3.17 :)