search

projecthorus / sondehub-tracker

🎈 Frontend for SondeHub Radiosonde Tracking
https://v2.sondehub.org
MIT License
61 stars 27 forks source link

Burst and Landing Icons don't completely convert to imperial units. #271

Closed smad333 closed 1 week ago

smad333 commented 2 years ago

As per title, burst and landing locations cannot be clicked for more information when in Imperial units mode only. Works fine if swapped back to metric units. Tried in Chrome, Explorer and Edge same result

darksidelemm commented 2 years ago

Should be fixed now :-)

Clearly I don't test the imperial unit setting enough...

smad333 commented 2 years ago

Many thanks, this now works, although the units are still metric on the popup box

darksidelemm commented 2 years ago

Hmm, which units? Can you post a screenshot please.

smad333 commented 2 years ago

image

smad333 commented 2 years ago

Altitude is correct but not ascent, burst or descent, same on burst popup

darksidelemm commented 2 years ago

Oh. Yes we don't convert those at the moment...

TheSkorm commented 1 week ago

Should be fixed on https://testing.v2.sondehub.org - can you confirm that the units are right?

smad333 commented 1 week ago

I have just checked and it looks like the units are correct with every combination of options. Well done and thank-you. Adam

On Wed, 20 Nov 2024, 03:12 Michaela Wheeler, @.***> wrote:

Should be fixed on https://testing.v2.sondehub.org - can you confirm that the units are right?

— Reply to this email directly, view it on GitHub https://github.com/projecthorus/sondehub-tracker/issues/271#issuecomment-2487255158, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4PDO6VGW3QN5MHSGLMEGDD2BP4ZBAVCNFSM6AAAAABSDRYKSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBXGI2TKMJVHA . You are receiving this because you authored the thread.Message ID: @.***>