search

projecthorus / sondehub-tracker

🎈 Frontend for SondeHub Radiosonde Tracking
https://v2.sondehub.org
MIT License
59 stars 24 forks source link

fixes #317 #318

Closed smwnwrght closed 2 months ago

smwnwrght commented 2 months ago

Reinstates landing predictions for landed sondes.

I have tested this but would appreciate a review as I don't understand the other code in updatePredictions() - hence draft pull request!

TheSkorm commented 2 months ago

Thanks @smwnwrght. Can you please remove the white space changes from the PR so that it's only the relevant code changes?

@darksidelemm this will show the predictions all the time, even after landed - not sure if we came to a conclusion as to if that was a good idea or not?

darksidelemm commented 2 months ago

I think this should be merged into the testing branch so we can check the behaviour out for a while.

smwnwrght commented 2 months ago

@TheSkorm have reverted whitespace (and cleaned up my code!)

smwnwrght commented 2 months ago

@darksidelemm Should I change this to the testing branch?

darksidelemm commented 2 months ago

Yes, I think it should be possible for you to re-target this to the testing branch. I've just made sure testing is in line with the master branch.

smwnwrght commented 2 months ago

@darksidelemm I have updated this to merge with the testing branch

darksidelemm commented 2 months ago

OK, I'll merge this in. it will be visible at testing.v2.sondehub.org