projecthorus / sondehub-tracker

🎈 Frontend for SondeHub Radiosonde Tracking
https://v2.sondehub.org
MIT License
61 stars 26 forks source link

Make coordinates clickable everywhere #338

Closed argilo closed 1 month ago

argilo commented 1 month ago

In a couple places, it's possible to click on coordinates to bring up an external mapping application:

Elsewhere, coordinates are displayed as plain text. It would be convenient to have coordinates displayed as a clickable link everywhere.

Here I extracted the common code for generating a link into a function (format_coordinates), and used it to display coordinates in the following places:

darksidelemm commented 1 month ago

Thanks for this! Could you please redirect this PR to the testing branch?

argilo commented 1 month ago

Sure, I'll do that in a few hours when I'm back at the computer.

argilo commented 1 month ago

I forgot to mention that I tested this on desktop and Android, but not with iPhone as I don't have a device to test with.

argilo commented 1 month ago

Rebased and re-tested.

darksidelemm commented 1 month ago

Thanks! This is also cleans up the code a bit which is nice. It would be good to have this on sondehub-amateur-tracker too.