projectinit / skrypt

A social networking application for MAXX Apprentices and Alumni
1 stars 3 forks source link

Subject: Rework Docker Compose #10

Closed ryanj27 closed 6 years ago

ryanj27 commented 6 years ago

Reason: The current Docker Compose configuration wasn't working. Add .dockerignore file to omit certain items from being tracked. Add .env file to .gitignore so environment variables aren't exposed. Redo Dockerfile to get environment running properly.

Note: Jonathon, I didn't realize you had made modifications to app.js and package.json. There may be a merge conflict in a couple places. If so, and they need to be resolved on my end just deny this and let me know. I'm getting the "Able to merge" note so hopefully there aren't any issues.

ryanj27 commented 6 years ago

I left you a comment in the PR.

ryanj27 commented 6 years ago

Actually, now that I think about it there shouldn't be any issues merging.