(bug) fixes guid validation for tenant ID

projectkudu / ARMClient

A simple command line tool to invoke the Azure Resource Manager API

http://blog.davidebbo.com/2015/01/azure-resource-manager-client.html

Other

316 stars 97 forks source link

(bug) fixes guid validation for tenant ID #21

Closed pjirsa closed 7 years ago

pjirsa commented 9 years ago

addresses issue #20 - tenantID does not need to be a GUID for AAD authentication.

davidebbo commented 9 years ago

@suwatch does that make sense? Couple notes:

there is another line with the same tenantId check (in 'token' command). Could it break to?
maybe instead of yanking the check there should be a more flexible EnsureTenantId which accepts either guid or domain name

suwatch01 commented 9 years ago

I am afraid the fix would take a little more than that since we cache token per tenantId guid. Passing other forms of tenantId would not be able to locate the cached token to be used (fallback to default) - hence the check. We just decided not to support it at the time. I will look over the codes and see what the complete fix would be.

pjirsa commented 9 years ago

Thanks for looking into this. It seems to be working (my fix) for the script my engineers built. I can get a list of all the ops being used if that is helpful.

suwatch commented 7 years ago

won't fix. If there is no other way for you to workaround, let me know.