projectkudu / slingshot

This project implements the Deploy To Azure button
http://azure.microsoft.com/blog/2014/11/13/deploy-to-azure-button-for-azure-websites-2/
51 stars 20 forks source link

way to distinguish optional parameters? #29

Closed kanreisa closed 9 years ago

kanreisa commented 9 years ago

Hi,

I'm using "Deploy to Azure button" to my this project (reichat). and I added azuredeploy.json to get initial parameters.

result:

problems:

solutions: (proposal)

expected:

(Heroku)

Thanks,

davidebbo commented 9 years ago

Not sure I completely follow. I see in your template that all parameters are optional. But from what I can see, the Deploy UI is correctly filling up all the boxes with the default values from your template, such that you can directly press Next. If a parameter was not optional, it wouldn't let you go to the next step.

Maybe I'm not understanding the problem?

kanreisa commented 9 years ago

@davidebbo It is a problem that it is difficult to understand visually. see expected, that is displaying "(optional)"

kanreisa commented 9 years ago

FYI: https://github.com/kanreisa/reichat/blob/master/app.json#L21 (app.json / for Heroku)

ehamai commented 9 years ago

I just spoke to David about this and I think we agree that this is a good idea. It looks like you've already discovered that "optional" parameters in ARM templates means an empty default value. So if we see that situation, we could tell the user that they don't need to fill it in.

ehamai commented 9 years ago

Woops. Accidentally closed the issue.

kanreisa commented 9 years ago

@Tuesdaysgreen thank you. I'm waiting for improvement!

kanreisa commented 9 years ago

:+1: