search

projectkudu / slingshot

This project implements the Deploy To Azure button
http://azure.microsoft.com/blog/2014/11/13/deploy-to-azure-button-for-azure-websites-2/
51 stars 20 forks source link

Site Name check does not seem to actually check for availability #69

Open DRediske opened 8 years ago

DRediske commented 8 years ago

If I deploy multiple times with the same site name, I expected the slingshot page to check for global uniqueness within Azure for the site name (based on "Name Is Available" language) and fail the check; however, it can pass the check but fail in deployment because of a name collision (which leads me to believe my understanding is incorrect). If Site name is checking for something else (but implying availability), this needs to be communicated. If it is supposed to avoid this collision, it is not doing so with complete accuracy.

ab

Also: please document those parameters with special treatment (collision checking, etc. ).

davidebbo commented 8 years ago

Strange, it works for me:

image

Maybe something is throwing off the check in your case. Try F12 to watch requests.

DRediske commented 8 years ago

Will check again and get back to you.

DRediske commented 8 years ago

It appears that if there is a default value (say, "contosoapp") it does not get checked. It would appear to to the equivalent of OnChanged() for when the box itself gets changed via user input.

davidebbo commented 8 years ago

Oh I see. Yes, that's likely the bug!