search

projectlombok / lombok

Very spicy additions to the Java programming language.
https://projectlombok.org/
Other
12.93k stars 2.4k forks source link

Close ZipOutputStream in eclipse dependency downloader #3765

Closed Rawi01 closed 1 month ago

Rawi01 commented 1 month ago

This PR fixes the broken eclipse tests

rzwitserloot commented 1 month ago

I added another commit on top; perhaps a strong word but I hate closeQuietly and hence it could not stand.

One problem with my updates is that most linter tools are likely to dislike it, but, the problem is, all linters are bad and wrong, at least in regards to streams. An annoyance; do we ugly up our code to satisfy linters, or do we die on the hill?

I'm a romantic, so, you know the choice I prefer :)