search

projectmesa / mesa-frames

Extension of mesa for performance and scalability
https://projectmesa.github.io/mesa-frames
Apache License 2.0
13 stars 4 forks source link

benchmark: Split Polars agent into native and concise #23

Closed rht closed 2 months ago

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

rht commented 2 months ago

I'm not sure about including the .png this early, because we are going to do lots of iterations on the code anyway. I will delete it once this PR is approved.

adamamer20 commented 2 months ago

I don't know why polars native has an initial spike. Maybe it's related to caching?

I'm not sure about including the .png this early, because we are going to do lots of iterations on the code anyway. I will delete it once this PR is approved.

OK for me.

rht commented 2 months ago

I can't reproduce the Polars spikes in your plot. This is what it looks like on main after you have merged this PR and I have pulled from upstream main: readme_plot_2

Polars version: 1.1.0 Python: 3.11

adamamer20 commented 2 months ago

Then it's probably related to perfplot on my laptop. I noticed that with a less powerful CPU and less RAM the collected time becomes more unstable.