wang-boyu commented 11 months ago

This PR depends on https://github.com/projectmesa/mesa-viz-tornado/pull/28, in which the ruff ignore list is defined in pyproject.toml.

Differences between this workflow and that in Mesa:

pytest is disabled here since there isn't any test case
no doc requires since there isn't a readthedocs site

Question: should we open the discussion board for this repo, or shall we use Mesa discussion?

rht commented 11 months ago

28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the `ruff` section of the pyproject.toml here instead.

Question: should we open the discussion board for this repo, or shall we use Mesa discussion?

Mesa discussion is easier, unless there are lots of new questions on the Tornado viz. I usually redirect people to the Solara viz instead.

wang-boyu commented 11 months ago

28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the ruff section of the pyproject.toml here instead.

Not sure whether I understand this correctly, but I added a pyproject.toml file with the ruff section, copied over from Mesa. This might result in merge conflicts in https://github.com/projectmesa/mesa-viz-tornado/pull/28 in the future if it's going to be updated.

Mesa discussion is easier, unless there are lots of new questions on the Tornado viz. I usually redirect people to the Solara viz instead.

Have redirected to Mesa discussions in the issue templates.

wang-boyu commented 11 months ago

Should be ready for review now.

projectmesa / mesa-viz-tornado

add github issue templates and workflows #35

28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the `ruff` section of the pyproject.toml here instead.

28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the `ruff` section of the pyproject.toml here instead.

projectmesa / mesa-viz-tornado

add github issue templates and workflows #35

28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the ruff section of the pyproject.toml here instead.

28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the ruff section of the pyproject.toml here instead.

28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the `ruff` section of the pyproject.toml here instead.

28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the `ruff` section of the pyproject.toml here instead.