projectpai / paicoin

Official repo of PAI Coin
https://projectpai.com
MIT License
63 stars 35 forks source link

Setting for maximum tickets to buy per block is reverted when starting ticket buyer #348

Closed mharvilla closed 3 years ago

mharvilla commented 4 years ago

As shown by the following commands, starting the ticket buyer overrides the previously set value of limit, the maximum number of tickets to purchase per block.

paicoin-cli ticketbuyerconfig
{
  "buytickets": false,
  "account": "",
  "maintain": 0,
  "votingAccount": "",
  "votingAddress": "",
  "rewardAddress": "",
  "poolFeeAddress": "",
  "poolFees": 0,
  "limit": 1,
  "minConf": 1
}
paicoin-cli setticketbuyerbalancetomaintain 1
paicoin-cli setticketbuyermaxperblock 10
paicoin-cli ticketbuyerconfig
{
  "buytickets": false,
  "account": "",
  "maintain": 100000000,
  "votingAccount": "",
  "votingAddress": "",
  "rewardAddress": "",
  "poolFeeAddress": "",
  "poolFees": 0,
  "limit": 10,
  "minConf": 1
}
paicoin-cli startticketbuyer "" 1
paicoin-cli ticketbuyerconfig
{
  "buytickets": true,
  "account": "",
  "maintain": 100000000,
  "votingAccount": "",
  "votingAddress": "",
  "rewardAddress": "",
  "poolFeeAddress": "",
  "poolFees": 0,
  "limit": 1,
  "minConf": 1
}
sebastianrusu commented 4 years ago

This has been resolved in PR: https://github.com/projectpai/paicoin/pull/349. The issue also extended to startautomaticvoter and startautomaticrevoker.