PR Pipeline for sk8s - Githubissues

projectriff-archive / ci

Concourse & Co.

https://ci.projectriff.io/

0 stars 1 forks source link

PR Pipeline for sk8s #14

Closed freynca closed 6 years ago

freynca commented 6 years ago

As a sk8s developer, when i'm working on a PR, i should be able to run Ci on that PR. I should also be able to use the helm chart for a PR to deploy the bits onto my own cluster (or minikube).

Create a pipeline to build sk8s PRs; integrate with GitHub.

Add publication of dev Helm charts to a dedicated bucket

jldec commented 6 years ago

Since the sk8s repo is public and PRs can include code from 3rd parties, we need to be a little careful with auto-Ci for PRs.

see https://circleci.com/docs/1.0/fork-pr-builds/

jldec commented 6 years ago

I updated the story to include helm-based PR workflow.

jldec commented 6 years ago

@freynca what was the reasoning for using a dedicated bucket / helm repo for PRs?

freynca commented 6 years ago

@jldec For clear separation of pre-release / test artifacts, and final artifacts. Kubo uses a similar model.

jldec commented 6 years ago

@freynca - I don't believe we have enough info today to decide that there will be exactly 2 categories of artifact (final and test)

Unless there is some other argument, i'd prefer to start with the opposite assumption - use one repo for all releases, and only split things out if/when necessary.

freynca commented 6 years ago

Closing as redundant.