projectriff-archive / ci

Concourse & Co.
https://ci.projectriff.io/
0 stars 1 forks source link

Convert to CI taskdir layout #39

Closed jchesterpivotal closed 6 years ago

jchesterpivotal commented 6 years ago

This PR:

Testing has been limited to using fly execute on updated tasks. While the pipeline definitions have been updated to the new paths, I have not felt comfortable triggering jobs willy-nilly without first having someone go over the PR.

Intended to satisfy #38.

ericbottard commented 6 years ago

Much much more readable overall in my opinion, I like this style better!

Sidenote: you've opened a PR by pushing to this upstream repo rather than your fork. Don't know if this was intentional, but we usually don't do this

ericbottard commented 6 years ago

This can happen in a separate PR, but I would also suggest renaming all git-* to *-sources (eg git-function-controller to function-controller-sources). This really feels weird to me, reading like some name of a command line tool or something...