search

projectriff-archive / cnab-k8s-installer-base

A CNAB bundle that allows creation of other declarative CNAB bundles
Apache License 2.0
0 stars 6 forks source link

Adopt new relocation approach #63

Closed glyn closed 5 years ago

glyn commented 5 years ago

Fixes https://github.com/projectriff/cnab-k8s-installer-base/issues/62

codecov[bot] commented 5 years ago

Codecov Report

Merging #63 into master will increase coverage by 1.44%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   85.88%   87.33%   +1.44%     
==========================================
  Files          13       13              
  Lines         574      529      -45     
==========================================
- Hits          493      462      -31     
+ Misses         54       47       -7     
+ Partials       27       20       -7
Impacted Files Coverage Δ
pkg/kab/relocate.go 100% <100%> (+15.55%) :arrow_up:
pkg/kab/k8sClient.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e020209...9f5bbf8. Read the comment docs.

sbawaska commented 5 years ago

@glyn Could you please run go mod tidy. I think github.com/pivotal/image-relocation can be safely removed.

glyn commented 5 years ago

@glyn Could you please run go mod tidy.

Done. Please see the second commit in this PR.

I think github.com/pivotal/image-relocation can be safely removed.

Yes, it has gone now along with its dependencies.