search

projectriff / builder

Home of the buildpack builder for riff
Apache License 2.0
2 stars 10 forks source link

Bump gcr.io/paketo-buildpacks/nodejs from 0.0.10 to 0.1.2 #435

Closed ghost closed 3 years ago

ghost commented 3 years ago

Bumps gcr.io/paketo-buildpacks/nodejs from 0.0.10 to 0.1.2.

ekcasey commented 3 years ago

Looks like this upgrade of paketo-buildpacks/nodejs is failing because of this change to the detection criteria in paketo-buildpacks/node-start. Previously if there was any *.js file in the application directory the nodejs buildpack would detect. Now it looks for specific files, which aren't present when build a riff node function.

The node-start buildpack exists to provide a start command and that command is overwritten by the projectriff/node-function-buildpack anyways. However, node-start is a required component of the paketo-buidpacks/nodejs buildpacks. Perhaps we want to move away from using the composite nodejs buildpack and instead compose a custom group like we do for java functions?

Another option would be to see if node-start can become optional in the nodejs buildpack.