search

projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works
https://projectstorm.cloud/react-diagrams
MIT License
8.65k stars 1.17k forks source link

Can't resolve '@emotion/core' in 'react-canvas-core' / add to peerDeps? #518

Open lukethacoder opened 4 years ago

lukethacoder commented 4 years ago

Can't resolve @emotion/core' in '***\node_modules\@projectstorm\react-canvas-core\dist

should '@emotion/core' be added to the packages for react-canvas-core, or is there a reason for keeping it clean? I understand that devs may choose to use other ways of styling, but the package falls over without it.

https://github.com/projectstorm/react-diagrams/blob/469dbc00aff2161ef48da210649971deeec066d8/packages/react-canvas-core/package.json#L31-L38

related: https://github.com/projectstorm/react-diagrams/issues/438 https://github.com/projectstorm/react-diagrams/issues/460#issuecomment-549390814_

renato-bohler commented 4 years ago

I think these dependencies should be added do peerDependencies indeed, and also the Getting Started section of the documentation should be updated.

Slurpgoose commented 4 years ago

npm install @emotion/core @emotion/styled dagre mathjs pathfinding paths-js resize-observer-polyfill closest lodash

386