projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.61k stars 1.17k forks source link

allow same port name on a node #663

Closed viennguyendeveloper closed 3 years ago

viennguyendeveloper commented 4 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

https://github.com/projectstorm/react-diagrams/issues/563 this is a opened issue.

Why?

In my project I need same port name on a node. And I think this.ports should have key as portID instead of portName.

How?

Feel good image:

LOL

dylanvorster commented 3 years ago

Closing since name in this case essentially is a unique ID, and you can implement this via extending the ports