search

projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works
https://projectstorm.cloud/react-diagrams
MIT License
8.6k stars 1.17k forks source link

Release new version compatible with React 17 #751

Open alexandernst opened 3 years ago

alexandernst commented 3 years ago

React 17 was just released. There are no breaking changes, but if I try to use it with react-diagrams, I get warnings about missing peer-dependencies (react-diagrams depends on react@16.x).

Can you release a new version making this package compatible with React 17? @dylanvorster

alexandernst commented 3 years ago

@dylanvorster I bugged devs from several libraries. All of them upgraded their libraries and added React 17 as an optional peer dependency. The only library that is missing is @reach/router, but none of the contributors is replying ( https://github.com/reach/router/issues/429 ).

If you release react-diagrams without waiting for this library to get upgraded, a warning will appear when running yarn install: 

warning "@storybook/addon-actions > @storybook/api > @reach/router@1.3.4" has incorrect peer dependency "react-dom@15.x || 16.x || 16.4.0-alpha.0911da3".

everything will work fine though.