projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.6k stars 1.17k forks source link

Support React 17 (Fixes #751) #755

Closed alexandernst closed 3 years ago

alexandernst commented 3 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

Upgrade to React 17

Why?

Because it will provide better support in the long term.

How?

By upgrading all libraries that haven't been upgraded to React 17 (bugging their creators), then updating this library.

alexandernst commented 3 years ago

This fixes #751

dylanvorster commented 3 years ago

Feels like we should just go all in with 17, and not even worry about 16, thoughts?

alexandernst commented 3 years ago

It doesn't hurt to leave React 16, at least for the moment. Even if 16 and 17 are completely compatible, a lot of projects haven't updated yet their peer dependencies, which means that if you leave only React 17, people will get warnings as the one I added in #751. It won't break anything, but it will show warnings when running "yarn install".

alexandernst commented 3 years ago

@dylanvorster Is there anything else I should add to this?

dylanvorster commented 3 years ago

Upgraded all the deps, its now in master