projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.6k stars 1.17k forks source link

Reroute (redistribute) links only, based on current nodes positions #731 #756

Closed h0111in closed 1 year ago

h0111in commented 3 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

added auto-redistribute without moving nodes

Why?

https://github.com/projectstorm/react-diagrams/issues/731

How?

Wrote an algorithm to find the path between nodes, instead of what Dagre was doing it.

Feel good image:

(Add your own one below :])

LOL

dylanvorster commented 3 years ago

Appreciate the work on this, but I think the refreshLinks() method needs to be broken up correctly. I also think we should find a way to make it automatic without the dev having to call this, potentially through the dagre engine register listeners to the core engine